workflows: replace API calls from bash with github-script#412659
Merged
wolfgangwalther merged 3 commits intoNixOS:masterfrom Jun 1, 2025
Merged
workflows: replace API calls from bash with github-script#412659wolfgangwalther merged 3 commits intoNixOS:masterfrom
wolfgangwalther merged 3 commits intoNixOS:masterfrom
Conversation
Granting the "issues: write" permission allows creating the "port to stable" label, if it doesn't exist, yet. This avoids failing the workflow when testing in a fork without that label.
After the stats were added with a header, the list of packages now appeared directly below it, without any separation.
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
philiptaron,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
3 tasks
philiptaron
approved these changes
May 31, 2025
github-script provides a better way to access the workflow's context than bash variables + interpolation. Especially when considering future changes, where you'll always be tempted to just use interpolation directly in bash code.
Contributor
Author
|
I applied my newly gained knowledge about pagination to the API call to fetch labels as well. Many labels - no problem! |
wolfgangwalther
force-pushed
the
ci-github-script
branch
from
78556b6 to
e344fdc
Compare
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Git push to origin failed for release-24.11 with exitcode 1 |
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
Contributor
|
Git push to origin failed for release-25.05 with exitcode 1 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a while, all new API calls in workflows were written with
actions/github-script. This PR is a refactor to rewrite the remaining bash scripts with it as well. For a little bit of background, see #412068 (comment). TLDR: github-script supports context natively, thus discouraging possibly insecure string interpolation.The eval workflow's "wait for target run" script is using a slightly different approach. Instead of waiting for the completion status of that run, it just checks for the availability of artifacts for download. This is the same approach that the newly introduced
reviewers.ymlworkflow uses and results in a bit simpler code, because fewer different API requests need to be made.Things done
Add a 👍 reaction to pull requests you find important.