Skip to content

treewide: fetchCargoVendor: inherit pname+version, part 2#412358

Merged
alyssais merged 1 commit intoNixOS:masterfrom
TomaSajt:cargo-deps-pname-version-2
May 30, 2025
Merged

treewide: fetchCargoVendor: inherit pname+version, part 2#412358
alyssais merged 1 commit intoNixOS:masterfrom
TomaSajt:cargo-deps-pname-version-2

Conversation

@TomaSajt
Copy link
Contributor

Part 2 for #412224, since it didn't catch everything.

This was a manually made PR by looking at files found by rg cargo -l | xargs rg 'name = "\$\{pname\}-\$\{version\}'

I left out a file pkgs/by-name/in/intiface-central/package.nix, because it had
name = "${pname}-${version}-cargo-deps";
which is not the default.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 30, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 30, 2025
@alyssais alyssais merged commit dcb247a into NixOS:master May 30, 2025
13 of 17 checks passed
@TomaSajt TomaSajt deleted the cargo-deps-pname-version-2 branch January 20, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants