protonup-rs: init at 0.9.0#412257
Merged
Aleksanaa merged 2 commits intoNixOS:masterfrom Jun 10, 2025
joshprk:master
Merged
Conversation
github-actions
bot
added
8.has: maintainer-list (update)
pluiedev
suggested changes
May 30, 2025
Member
pluiedev
left a comment
pluiedev
left a comment
There was a problem hiding this comment.
Welcome to Nixpkgs ❤️ Here are a few suggestions
pluiedev
added
the
12.first-time contribution
github-actions
bot
added
10.rebuild-darwin: 1
Contributor
Author
|
Made the requested changes, and thanks! |
github-actions
bot
added
10.rebuild-darwin: 0
pluiedev
approved these changes
May 30, 2025
Member
pluiedev
left a comment
pluiedev
left a comment
There was a problem hiding this comment.
Diff LGTM, will try to build it myself later
Member
|
dtomvan
added
the
12.approvals: 2
dtomvan
approved these changes
Jun 5, 2025
Contributor
dtomvan
left a comment
dtomvan
left a comment
There was a problem hiding this comment.
I'm sorry for not responding earlier. Couple nits, but approving anyways as it builds and runs fine.
wegank
removed
the
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Rust app to Install and Update GE-Proton for Steam, and Wine-GE for Lutris
https://github.com/auyer/Protonup-rs
Resolves #391668
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.