make-symlinks-relative.sh: optimize - use multiple cores#411981
Merged
Mic92 merged 1 commit intoNixOS:stagingfrom Dec 4, 2025
Merged
make-symlinks-relative.sh: optimize - use multiple cores#411981Mic92 merged 1 commit intoNixOS:stagingfrom
Mic92 merged 1 commit intoNixOS:stagingfrom
Conversation
github-actions
bot
added
10.rebuild-darwin: 5001+
Mic92
reviewed
Jun 6, 2025
Member
Author
|
I also added more tests for |
wegank
added
the
2.status: merge conflict
Member
Author
|
Since parallelMap and parallelRun were reverted, I also reverted this optimization to the original implementation. Please have a look again @Mic92 |
nixpkgs-ci
bot
removed
the
2.status: merge conflict
This optimizes the performance of the hook on machines with multiple cores. The previous implementation was slow, as it was launching two extra processes per symlink (readlink and ln) while not making use of multiprocessing. The following improvements were made: - don't even execute the hook if dontRewriteSymlinks is set - replace multiple find calls with single find call over all outputs - use xargs -P to process symlinks in parallel - add test to check that the hook operates as expected
nixpkgs-ci
bot
added
10.rebuild-linux-stdenv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This optimizes the performance of the hook on machines with multiple cores.
The previous implementation was slow, as it was launching two extra processes per symlink (readlink and ln) while not making use of multiprocessing.
The following improvements were made:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.