lib.fileset: support fileFilter for file sets#411409
Closed
wolfgangwalther wants to merge 2 commits intoNixOS:masterfrom
Closed
lib.fileset: support fileFilter for file sets#411409wolfgangwalther wants to merge 2 commits intoNixOS:masterfrom
wolfgangwalther wants to merge 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: lib
wolfgangwalther
force-pushed
the
lib-fileset-virtual
branch
from
b5c5ded to
00e4a48
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
2 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
2 tasks
wolfgangwalther
force-pushed
the
lib-fileset-virtual
branch
from
00e4a48 to
a3f93bf
Compare
wolfgangwalther
changed the title
Contributor
Author
|
I removed the "virtual files" part of this and reduced it to only support |
wolfgangwalther
requested review from
hsjobeki and
infinisil
and removed request for
hsjobeki and
infinisil
Not supporting file sets for fileFilter was a conscious decision when the function was introduced. The only argument in favor of that decision was future extensibility for predicate properties like `subpath` or `components`. Since those operate on the full path, not only on the filename, we could introduce a new function `pathFilter` in the future, which supports only paths, but also path-based filtering. Thus, the door is not closed for that extension.
wolfgangwalther
force-pushed
the
lib-fileset-virtual
branch
from
a3f93bf to
4400053
Compare
Contributor
Author
|
There seems to be no interest in this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not supporting file sets for fileFilter was a conscious decision when the function was introduced. The only argument in favor of that decision was future extensibility for predicate properties like
subpathorcomponents. Since those operate on the full path, not only on the filename, we could introduce a new functionpathFilterin the future, which supports only paths, but also path-based filtering. Thus, the door is not closed for that extension.Things done
Add a 👍 reaction to pull requests you find important.