render50: init at 9.2.7 by ethancedwards8 · Pull Request #411292 · NixOS/nixpkgs

ethancedwards8 · 2025-05-27T04:23:21Z

Things done

Add a 👍 reaction to pull requests you find important.

ethancedwards8 · 2025-05-28T00:49:04Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 411292

Logs: https://github.com/ethancedwards8/nixpkgs-review-gha/actions/runs/15288656933

Download packages from cache:

x86_64-linux

nix-store -r --add-root nixpkgs-pr-411292-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://ethancedwards8.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  ethancedwards8.cachix.org-1:YMasjqyFnDreRQ9GXmnPIshT3tYyFHE2lUiNhbyIxOc=
  ' \
  /nix/store/y70m96b1238jwkns4qk229xipzk6amy4-render50-9.2.8 \
  /nix/store/bx122as1n1cr5p2kygvczc13dk447g5s-render50-9.2.8-dist

aarch64-linux

nix-store -r --add-root nixpkgs-pr-411292-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://ethancedwards8.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  ethancedwards8.cachix.org-1:YMasjqyFnDreRQ9GXmnPIshT3tYyFHE2lUiNhbyIxOc=
  ' \
  /nix/store/4q9232753588x75akvaf57fwzf613dhh-render50-9.2.8 \
  /nix/store/hpm0nsjlri7wmnwfv0pfaa9m5hl8pbz9-render50-9.2.8-dist

`x86_64-linux` (sandbox = true)

✅ 2 packages built:

render50
render50.dist

`aarch64-linux` (sandbox = true)

✅ 2 packages built:

render50
render50.dist

`x86_64-darwin` (sandbox = true)

❌ 2 packages failed to build:

render50
render50.dist

`aarch64-darwin` (sandbox = true)

❌ 2 packages failed to build:

render50
render50.dist

ethancedwards8 · 2025-05-28T20:45:35Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 411292

Logs: https://github.com/ethancedwards8/nixpkgs-review-gha/actions/runs/15310047882

Download packages from cache:

x86_64-linux

nix-store -r --add-root nixpkgs-pr-411292-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://ethancedwards8.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  ethancedwards8.cachix.org-1:YMasjqyFnDreRQ9GXmnPIshT3tYyFHE2lUiNhbyIxOc=
  ' \
  /nix/store/y70m96b1238jwkns4qk229xipzk6amy4-render50-9.2.8 \
  /nix/store/bx122as1n1cr5p2kygvczc13dk447g5s-render50-9.2.8-dist

aarch64-linux

nix-store -r --add-root nixpkgs-pr-411292-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://ethancedwards8.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  ethancedwards8.cachix.org-1:YMasjqyFnDreRQ9GXmnPIshT3tYyFHE2lUiNhbyIxOc=
  ' \
  /nix/store/4q9232753588x75akvaf57fwzf613dhh-render50-9.2.8 \
  /nix/store/hpm0nsjlri7wmnwfv0pfaa9m5hl8pbz9-render50-9.2.8-dist

`x86_64-linux` (sandbox = true)

✅ 2 packages built:

render50
render50.dist

`aarch64-linux` (sandbox = true)

✅ 2 packages built:

render50
render50.dist

`x86_64-darwin` (sandbox = true)

⏩ 2 packages marked as broken and skipped:

render50
render50.dist

`aarch64-darwin` (sandbox = true)

⏩ 2 packages marked as broken and skipped:

render50
render50.dist

pkgs/by-name/re/render50/package.nix

GaetanLepage · 2025-05-29T17:54:36Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 411292
Commit: c32b3e5aeb8dba44b48f09222c29ea88c44101e0

`x86_64-linux`

✅ 2 packages built:

render50
render50.dist

`aarch64-linux`

✅ 2 packages built:

render50
render50.dist

pkgs/by-name/re/render50/package.nix

GaetanLepage · 2025-05-31T22:32:36Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 411292
Commit: 4e06aa413c2b4067e33b89633ba415cf552331d0

`x86_64-linux`

✅ 2 packages built:

render50
render50.dist

`aarch64-linux`

✅ 2 packages built:

render50
render50.dist

GaetanLepage

LGTM

pkgs/by-name/re/render50/package.nix

GaetanLepage

weasyprint has been properly disabled on darwin in #412183.
You should now be able to drop meta.badPlatforms.

ethancedwards8 · 2025-06-01T02:15:49Z

Thanks for handling that. I appreciate it!

GaetanLepage · 2025-06-01T08:35:06Z

Were you able to test the final executable?

I get:

[nix-shell:~/.cache/nixpkgs-review/pr-411292-3]$ render50
/nix/store/sqx89ss1hw2cb336aq1j8dhf8rz8dv22-render50-9.2.8/bin/.render50-wrapped: /nix/store/sqx89ss1hw2cb336aq1j8dhf8rz8dv22-render50-9.2.8/bin/render50: line 3: syntax error near unexpected token `lambda'
/nix/store/sqx89ss1hw2cb336aq1j8dhf8rz8dv22-render50-9.2.8/bin/.render50-wrapped: /nix/store/sqx89ss1hw2cb336aq1j8dhf8rz8dv22-render50-9.2.8/bin/render50: line 3: `import sys;import site;import functools;sys.argv[0] = '/nix/store/sqx89ss1hw2cb336aq1j8dhf8rz8dv22-render50-9.2.8/bin/render50';functools.reduce(lambda k, p: site.addsitedir(p, k), ['/nix/store/sqx89ss1hw2cb336aq1j8dhf8rz8dv22-render50-9.2.8/lib/python3.12/site-packages','/nix/store/sv23z1yrc1hqj5946a54c26m8rjrl4wn-python3.12-backports-shutil-which-3.5.2/lib/python3.12/site-packages','/nix/store/593cjiiw1mbdw706lgbf13x9vdvgh9kr-python3.12-braceexpand-0.1.7/lib/python3.12/site-packages','/nix/store/aiaa3p27xsmaag07x2p0w9hqfdm8rm8s-python3.12-beautifulsoup4-4.12.3/lib/python3.12/site-packages','/nix/store/2czhgz2rxnwknbs6whpab1dm9j579xfx-python3.12-chardet-5.2.0/lib/python3.12/site-packages','/nix/store/l3dfz6h8vppq8xjicjngiprgij1n0nzg-python3.12-soupsieve-2.6/lib/python3.12/site-packages','/nix/store/n0k49cxakminrdlkb4mh0psvalnbw62v-python3.12-natsort-8.4.0/lib/python3.12/site-packages','/nix/store/0hcl3fafbksjlcl65prrmi6as7wqkah0-python3.12-fastnumbers-5.1.0/lib/python3.12/site-packages','/nix/store/s12xbqdc432pxy4pcx9j7sz6wkm6w1zk-python3.12-typing-extensions-4.13.2/lib/python3.12/site-packages','/nix/store/qw47r7fzwf0r2yf3lc02rscc0myk7xn3-python3.12-pyicu-2.15/lib/python3.12/site-packages','/nix/store/6q20iq74fqy73ryq7xs5szbvka52s1lf-python3.12-pygments-2.19.1/lib/python3.12/site-packages','/nix/store/mb9qbhfys5sqygbmfisxfvfvh4bdzwp8-python3.12-pypdf-5.5.0/lib/python3.12/site-packages','/nix/store/p27z6sfjb5va5ccbzljcw7n79b0chnj7-python3.12-requests-2.32.3/lib/python3.12/site-packages','/nix/store/pazf30dxg3zkk81k013j781ga95hvdps-python3.12-certifi-2025.01.31/lib/python3.12/site-packages','/nix/store/yf60x59dk0mdrkmbcmibrrmk1v44z4ym-python3.12-charset-normalizer-3.4.1/lib/python3.12/site-packages','/nix/store/90afwxppk4864vr7j6vmphsyxpnl52rg-python3.12-idna-3.10/lib/python3.12/site-packages','/nix/store/i9bgc80gb1qbdvz247h8lj2cls491fwz-python3.12-urllib3-2.3.0/lib/python3.12/site-packages','/nix/store/wf3dq7gqmd7ilzg1k13zgcvyk2l26lra-python3.12-six-1.17.0/lib/python3.12/site-packages','/nix/store/01g515pjmzxqzfdfgw7yjr49i00f6qw4-python3.12-termcolor-3.0.0/lib/python3.12/site-packages','/nix/store/fic9qzi4iy6fwbfcf1zf6mrkiy28yl6j-python3.12-weasyprint-65.1/lib/python3.12/site-packages','/nix/store/cm7pn7x0z9vbib4a7kdjc8z721i92797-python3.12-cffi-1.17.1/lib/python3.12/site-packages','/nix/store/p7hwn4i018p9vib9canjwj3na94c7a5i-python3.12-pycparser-2.22/lib/python3.12/site-packages','/nix/store/ijlxgg5x53sc6jsc3linkcf5q7q19vbp-python3.12-cssselect2-0.8.0/lib/python3.12/site-packages','/nix/store/6xxvz7s7qs89b8w2lwp5mlly33f3jrxn-python3.12-tinycss2-1.4.0/lib/python3.12/site-packages','/nix/store/csfg6xpqbjpvpsxyi74fjcaq6b32h2m1-python3.12-webencodings-0.5.1/lib/python3.12/site-packages','/nix/store/c45b4l5d7l0bcqgdlzcy6xvnf36nk9rj-python3.12-fonttools-4.56.0/lib/python3.12/site-packages','/nix/store/hz80khypkc1q1axp2bbyqmpyiiqd628i-python3.12-pillow-11.2.1/lib/python3.12/site-packages','/nix/store/ksghrag3a18f5islnrq3ggld54jjnwwd-python3.12-pydyf-0.11.0/lib/python3.12/site-packages','/nix/store/84510a26252a51fmsmbkvqk32cggrnva-python3.12-pyphen-0.17.2/lib/python3.12/site-packages','/nix/store/k8fzs7dnx2xfbngp5lchagqkzh4xls99-python3.12-tinyhtml5-2.0.0/lib/python3.12/site-packages','/nix/store/l4pxy2w0irvcivpfbs4b5rm92jr7g75a-python3.12-brotli-1.1.0/lib/python3.12/site-packages','/nix/store/dwzmjhx746dqrby12ajv3qhr5r0k2n3h-python3.12-zopfli-0.2.3/lib/python3.12/site-packages'], site._init_pathinfo());'

ethancedwards8 · 2025-06-05T03:26:23Z

It works for me?...

ece in 🌐 archpc in ~/.cache/nixpkgs-review/pr-411292 via ❄️  impure (review-shell) ❯ render50 --version
render50 9.2.8

GaetanLepage · 2025-06-05T07:04:37Z

It works for me?...

ece in 🌐 archpc in ~/.cache/nixpkgs-review/pr-411292 via ❄️  impure (review-shell) ❯ render50 --version
render50 9.2.8

Very weird... I still gets the same error.

I am executing /nix/store/sqx89ss1hw2cb336aq1j8dhf8rz8dv22-render50-9.2.8/bin/render50 on x86_64-linux.

ethancedwards8 · 2025-06-05T16:46:30Z

I don't even have that path. The most recent commit's path for me is /nix/store/isb8z4pf2wvr8g42c9hbc7290jbs9i0v-render50-9.2.8/bin/render50

The derivation should not build for you if it cannot be executed as versionCheckHook should catch the execution fail?

GaetanLepage · 2025-06-05T23:02:33Z

I don't even have that path. The most recent commit's path for me is /nix/store/isb8z4pf2wvr8g42c9hbc7290jbs9i0v-render50-9.2.8/bin/render50

The derivation should not build for you if it cannot be executed as versionCheckHook should catch the execution fail?

I rebased on master before building.

Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>

ethancedwards8 · 2025-06-06T00:32:45Z

I have too. Just force pushed that rebase. Still works for me 🤷 Same binary path as well. /nix/store/isb8z4pf2wvr8g42c9hbc7290jbs9i0v-render50-9.2.8/bin/render50

GaetanLepage · 2025-06-06T08:44:50Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 411292
Commit: f81f12278b467f4b19c9e2bb91589ad2939e6a06

`x86_64-linux`

✅ 2 packages built:

render50
render50.dist

`aarch64-linux`

✅ 2 packages built:

render50
render50.dist

GaetanLepage · 2025-06-06T08:45:52Z

I have too. Just force pushed that rebase. Still works for me 🤷 Same binary path as well. /nix/store/isb8z4pf2wvr8g42c9hbc7290jbs9i0v-render50-9.2.8/bin/render50

This is very weird...
I have binary /nix/store/sqx89ss1hw2cb336aq1j8dhf8rz8dv22-render50-9.2.8/bin/render50 and it still fails to run with the same error...

GaetanLepage · 2025-06-06T14:22:54Z

I think the nixpkgs-review environment is just flaky. I was able to run it just fine.

GaetanLepage

Thanks!

ethancedwards8 · 2025-06-06T14:38:23Z

Thank you for your patience and for working with me!

ethancedwards8 force-pushed the render50 branch from 806e3ad to 34641eb Compare May 27, 2025 04:26

ethancedwards8 force-pushed the render50 branch from 34641eb to 1edeb81 Compare May 27, 2025 17:30

ethancedwards8 force-pushed the render50 branch from 1edeb81 to 4997cb7 Compare May 28, 2025 01:19

ethancedwards8 requested a review from a user May 29, 2025 04:02

ghost approved these changes May 29, 2025

View reviewed changes

ethancedwards8 requested review from GaetanLepage and Sigmanificient May 29, 2025 04:53

GaetanLepage reviewed May 29, 2025

View reviewed changes

pkgs/by-name/re/render50/package.nix Outdated Show resolved Hide resolved

pkgs/by-name/re/render50/package.nix Outdated Show resolved Hide resolved

ethancedwards8 force-pushed the render50 branch from 4997cb7 to c32b3e5 Compare May 29, 2025 17:08

ethancedwards8 requested a review from GaetanLepage May 29, 2025 17:09

github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels May 29, 2025

GaetanLepage reviewed May 29, 2025

View reviewed changes

pkgs/by-name/re/render50/package.nix Outdated Show resolved Hide resolved

ethancedwards8 force-pushed the render50 branch 2 times, most recently from 377dc9e to 4e06aa4 Compare May 29, 2025 18:44

ethancedwards8 requested a review from GaetanLepage May 29, 2025 18:46

GaetanLepage approved these changes May 31, 2025

View reviewed changes

GaetanLepage reviewed May 31, 2025

View reviewed changes

pkgs/by-name/re/render50/package.nix Outdated Show resolved Hide resolved

GaetanLepage requested changes May 31, 2025

View reviewed changes

ethancedwards8 force-pushed the render50 branch from 4e06aa4 to 6f6d420 Compare June 1, 2025 02:15

render50: init at 9.2.7

f81f122

Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>

ethancedwards8 force-pushed the render50 branch from 6f6d420 to f81f122 Compare June 6, 2025 00:32

GaetanLepage approved these changes Jun 6, 2025

View reviewed changes

GaetanLepage merged commit d6fea41 into NixOS:master Jun 6, 2025
15 of 18 checks passed

Uh oh!

Conversation

ethancedwards8 commented May 27, 2025

Things done

Uh oh!

ethancedwards8 commented May 28, 2025

nixpkgs-review result

x86_64-linux (sandbox = true)

aarch64-linux (sandbox = true)

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

ethancedwards8 commented May 28, 2025

nixpkgs-review result

x86_64-linux (sandbox = true)

aarch64-linux (sandbox = true)

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

Uh oh!

Uh oh!

GaetanLepage commented May 29, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

Uh oh!

Uh oh!

GaetanLepage commented May 31, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

Uh oh!

GaetanLepage left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GaetanLepage left a comment

Choose a reason for hiding this comment

Uh oh!

ethancedwards8 commented Jun 1, 2025

Uh oh!

GaetanLepage commented Jun 1, 2025

Uh oh!

ethancedwards8 commented Jun 5, 2025

Uh oh!

GaetanLepage commented Jun 5, 2025

Uh oh!

ethancedwards8 commented Jun 5, 2025

Uh oh!

GaetanLepage commented Jun 5, 2025

Uh oh!

ethancedwards8 commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GaetanLepage commented Jun 6, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

Uh oh!

GaetanLepage commented Jun 6, 2025

Uh oh!

GaetanLepage commented Jun 6, 2025

Uh oh!

GaetanLepage left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ethancedwards8 commented Jun 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`nixpkgs-review` result

`x86_64-linux` (sandbox = true)

`aarch64-linux` (sandbox = true)

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)

`nixpkgs-review` result

`x86_64-linux` (sandbox = true)

`aarch64-linux` (sandbox = true)

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

ethancedwards8 commented Jun 6, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`