[Backport staging-24.11] qrencode: fix build failure#410581
Merged
philiptaron merged 2 commits intoNixOS:staging-24.11from May 26, 2025
stefano-m:backport-fix-qrencode-build-failure
Merged
[Backport staging-24.11] qrencode: fix build failure#410581philiptaron merged 2 commits intoNixOS:staging-24.11from stefano-m:backport-fix-qrencode-build-failure
philiptaron merged 2 commits intoNixOS:staging-24.11from
stefano-m:backport-fix-qrencode-build-failure
Conversation
13 tasks
Prince213
requested changes
May 24, 2025
Member
Prince213
left a comment
Prince213
left a comment
There was a problem hiding this comment.
Please format with nix fmt.
Also, please use -x when backporting changes.
Contributor
Author
I am fixing the build failures. I can't cherry pick because the file is different between the two branches. |
github-actions
bot
added
10.rebuild-darwin: 101-500
The source tarball is no longer available at <https://fukuchi.org/works/qrencode/qrencode-4.1.1.tar.gz>. ``` $ curl -I 'https://fukuchi.org/works/qrencode/qrencode-4.1.1.tar.gz' HTTP/1.1 404 Not Found Date: Sat, 17 May 2025 07:13:20 GMT Server: Apache/2.4.62 (Debian) Strict-Transport-Security: max-age=31536000 Content-Type: text/html; charset=iso-8859- ``` However, we can download it from the official repository on GitHub as mentioned in the project's home page[1]. To make the package build, we use autoreconfHook to mimic the repo's `autogen.sh` because the GitHub repo does not contain the configure script as mentioned in the project's README[2]: > If there is no "configure" script in the source code directory, run > "autogen.sh" at first to generate it - this is mandatory if you downloaded > the source from GitHub. [1] https://web.archive.org/web/20250413215821/https://fukuchi.org/en/works/qrencode/ [2] https://github.com/fukuchi/libqrencode/blob/50b3e5725cafccfde038c0833cdaa5b1c28491e2/README.md#compile--install (cherry picked from commit 04db9fe)
Nix fails with an infinite recursion error When running the qrencode tests with SDL2 in nativeCheckInputs. Removing the dependency fixes the error and the tests still run successfully. (cherry picked from commit b8246ba)
Contributor
|
We can use |
Contributor
Author
Sorry about that @philiptaron and @Prince213 My bad. Thank you for fixing the commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a manual backport of #407835
Ref: #407835 (comment)
Cc @philiptaron
Add a 👍 reaction to pull requests you find important.