testers.hasCmakeConfigModules: init#410516
Merged
NickCao merged 3 commits intoNixOS:masterfrom Jun 4, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: testing
qbisi
force-pushed
the
testCmake
branch
2 times, most recently
from
468ef28 to
e7e83c2
Compare
github-actions
bot
added
10.rebuild-darwin: 101-500
qbisi
force-pushed
the
testCmake
branch
5 times, most recently
from
6fea2b8 to
9d988c0
Compare
github-actions
bot
added
the
8.has: documentation
qbisi
force-pushed
the
testCmake
branch
3 times, most recently
from
16c2ce6 to
9eea041
Compare
Contributor
Author
|
@risicle ask for your comment/review, this hasCmakeConfigModules test is highly inspired by hasPkgConfigModule, hence a ping. |
Contributor
|
@qbisi , this PR broke OTB package . Why change of |
Contributor
Author
|
See #410844 |
imincik
reviewed
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tester write a mininal CmakeLists.txt to test if the finalPackages and all its dependencies can be imported via
find_package($modulename NO_MODULE REQUIRED)It is used to check if the finalPackage does correctly propagate all the needed packages required in *config.cmake module.
As a example, we check the library c-blosc2 with hasCmakeConfigModules.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.