Skip to content

fx: 36.0.0 -> 36.0.3#410458

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
phanirithvij:fx-minor-refactor
May 31, 2025
Merged

fx: 36.0.0 -> 36.0.3#410458
wolfgangwalther merged 1 commit intoNixOS:masterfrom
phanirithvij:fx-minor-refactor

Conversation

@phanirithvij
Copy link
Member

@phanirithvij phanirithvij commented May 24, 2025

  • 36.0.0 -> 36.0.3
  • refactored the derivation

closed the automated pr #410250
if that is not okay feel free to close mine and reopen that one

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 24, 2025
@nix-owners nix-owners bot requested a review from figsoda May 24, 2025 09:39
@phanirithvij

This comment was marked as outdated.

and refactor

Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
@phanirithvij phanirithvij changed the title fx: 36.0.0 -> 36.0.2 fx: 36.0.0 -> 36.0.3 May 31, 2025
@phanirithvij
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 410458

Logs: https://github.com/phanirithvij/nixpkgs-review-gha/actions/runs/15362222088


x86_64-linux (sandbox = true)

✅ 1 package built:
  • fx

aarch64-linux (sandbox = true)

✅ 1 package built:
  • fx

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • fx

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • fx

@phanirithvij phanirithvij added the 8.has: package (update) This PR updates a package to a newer version label May 31, 2025
@phanirithvij
Copy link
Member Author

@wolfgangwalther could you review

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented May 31, 2025

Personally, I think version update + refactor should always be split into two commits. You can find some more discussion around it here: #400934 (comment) (and elsewhere in that PR, too).

Especially in this case I don't understand why the automated PR wasn't kept for the update (Edit: ah, it's a newer patch OK) and the refactor added separately - I don't see the connection between either of the two.

But the changes LGTM, so I won't block on that.

@wolfgangwalther wolfgangwalther merged commit 8a5df70 into NixOS:master May 31, 2025
17 of 21 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 31, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-410458-to-release-25.05 origin/release-25.05
cd .worktree/backport-410458-to-release-25.05
git switch --create backport-410458-to-release-25.05
git cherry-pick -x 4460656436381d1f00f43b7e3b26e3fb6b4acef0

@phanirithvij phanirithvij deleted the fx-minor-refactor branch May 31, 2025 09:59
@phanirithvij
Copy link
Member Author

version update + refactor should always be split into two commits

I will follow that from now thanks

@mdaniels5757 mdaniels5757 added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants