Conversation
This comment was marked as outdated.
This comment was marked as outdated.
5fbb62e to
0886ac3
Compare
and refactor Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
0886ac3 to
4460656
Compare
|
|
@wolfgangwalther could you review |
|
Personally, I think version update + refactor should always be split into two commits. You can find some more discussion around it here: #400934 (comment) (and elsewhere in that PR, too). Especially in this case I don't understand why the automated PR wasn't kept for the update (Edit: ah, it's a newer patch OK) and the refactor added separately - I don't see the connection between either of the two. But the changes LGTM, so I won't block on that. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-410458-to-release-25.05 origin/release-25.05
cd .worktree/backport-410458-to-release-25.05
git switch --create backport-410458-to-release-25.05
git cherry-pick -x 4460656436381d1f00f43b7e3b26e3fb6b4acef0 |
I will follow that from now thanks |
closed the automated pr #410250
if that is not okay feel free to close mine and reopen that one
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.