nototools: move to top-level#410417
Merged
mweinelt merged 5 commits intoNixOS:masterfrom May 25, 2025
Merged
Conversation
github-actions
bot
added
6.topic: python
nix-owners
bot
requested review from
Mathnerd314,
emilazy,
lucasew,
natsukium and
sternenseemann
Member
|
We might as well drop typed-ast for good. |
Member
Author
But nototools does in fact depend on it. EDIT: Never mind, seems like it's listed in requirements.txt for no reason. |
Member
Author
|
Contributor
|
This breaks anything that uses |
typedrat
added a commit
to typedrat/apple-emoji-linux
that referenced
this pull request
May 28, 2025
NixOS/nixpkgs#410417 moved `nototools` to the top level because it depends on otherwise-unused and deprecated python library `typed-ast`. This is a slightly ugly way to handle looking for the package in the right places either way.
Member
Author
|
Is there any documentation of this API being public? |
lboklin
pushed a commit
to lboklin/noto-emoji-ogblobs
that referenced
this pull request
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #408185 (comment)
cc @trofi
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.