Closed
Conversation
Also resolved two below build issues * Broken symlinks: nixpkgs build now checks for broken symlinks, this PR adds all the relevant directories back to the out dir so all symlinks are intact. * Missing npm: wrangler specifies an older of pnpm than the one in pnpm_9 as used in the build process, this PR patches the package.json to use the pnpm version that is currently present in the build environment, this way when we update pnpm_9 again wrangler will still build.
ezrizhu
changed the title
github-actions
bot
added
10.rebuild-darwin: 1
Member
Author
|
oh bruh didnt see the old one got updated, closing. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #409155
fixes #409155
fixes #381980
related: #377334
Upstream Changelog: https://github.com/cloudflare/workers-sdk/releases/tag/wrangler%404.16.0
Besides the version update, I also resolved two issues that prevented us from updating wrangler (context in the update request issue).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.