Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
NyCodeGHG
approved these changes
May 20, 2025
JohnRTitor
reviewed
May 20, 2025
Member
JohnRTitor
left a comment
JohnRTitor
left a comment
There was a problem hiding this comment.
Does this need to be backported as well?
Contributor
Author
I don't think so. On the |
13 tasks
13 tasks
Contributor
|
It's be nice to have a mention of why hashes change for an update like this. I also hit this hash-mismatch and while it was nice to see that there was already a PR, it did give me pause to wonder if I was going to update my hash to a hacker-replaced version containing malware. |
Member
|
#383876 took a while to merge and playwright was updated in the meantime, so the hashes went out of date, but it got only noticed after the merge, that shouldn't have happened, but it did, so the follow up PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.