gitlab-runner: Make Bash a runtime dependency to fix clear-docker-cache.#409109
Merged
leona-ya merged 1 commit intoNixOS:masterfrom May 20, 2025
Merged
Conversation
13 tasks
helsinki-Jo
approved these changes
May 20, 2025
leona-ya
approved these changes
May 20, 2025
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Git push to origin failed for release-24.11 with exitcode 1 |
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Git push to origin failed for release-24.11 with exitcode 1 |
Contributor
|
Git push to origin failed for release-25.05 with exitcode 1 |
1 similar comment
Contributor
|
Git push to origin failed for release-25.05 with exitcode 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#395906 (comment)
Bash was accidentally moved from a runtime to a build time dependency in a prior PR which broke the
clear-docker-cacheBash script output. Moving it back to a runtime dependency.cat /nix/store/v2zaq82pi58pijfs5xlzx3zhzyv0n6fg-gitlab-runner-17.11.0/bin/clear-docker-cache/nix/store/v2zaq82pi58pijfs5xlzx3zhzyv0n6fg-gitlab-runner-17.11.0/bin/clear-docker-cache helpINFO: Docker installation not found, skipping clear-docker-cacheNeeds to be backported to 24.11.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.