Skip to content

[Backport release-25.05] playwright-driver: use upstream chromium build#408861

Closed
nixpkgs-ci[bot] wants to merge 2 commits intorelease-25.05from
backport-383876-to-release-25.05
Closed

[Backport release-25.05] playwright-driver: use upstream chromium build#408861
nixpkgs-ci[bot] wants to merge 2 commits intorelease-25.05from
backport-383876-to-release-25.05

Conversation

@nixpkgs-ci
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented May 19, 2025

Bot-based backport to release-25.05, triggered by a label in #383876.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-committer, if you find that it is not acceptable, leave a comment.

NyCodeGHG added 2 commits May 19, 2025 20:53
Use the exact chromium version upstream uses for playwright, to prevent breaking from browser updates in nixpkgs.

(cherry picked from commit 18f3489)
@github-actions github-actions bot added 4.workflow: backport This targets a stable branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 19, 2025
@nix-owners nix-owners bot requested a review from kalekseev May 19, 2025 21:00
@NyCodeGHG NyCodeGHG added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 20, 2025
url = "https://playwright.azureedge.net/builds/chromium/${revision}/chromium-${suffix}.zip";
hash =
{
x86_64-linux = "sha256-9bK8HOGoQY5kYYfJypYHeuAoVlXIh/1tv1IsXPpUTpA=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be sha256-7oQQCAIt1VJiMNFEJO40K8oENK/L0BICXm2D/3fZ8bA= for x86_64-linux.

See: #383876 (comment)

@NyCodeGHG
Copy link
Member

NyCodeGHG commented May 23, 2025

Closing in favor of #410070, since we also need the hash fix backported :)

@NyCodeGHG NyCodeGHG closed this May 23, 2025
@wolfgangwalther wolfgangwalther deleted the backport-383876-to-release-25.05 branch May 26, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants