vimPlugins: include all source in lua-based plugins, updates#408700
Closed
dtomvan wants to merge 8 commits intoNixOS:masterfrom
Closed
vimPlugins: include all source in lua-based plugins, updates#408700dtomvan wants to merge 8 commits intoNixOS:masterfrom
dtomvan wants to merge 8 commits intoNixOS:masterfrom
Conversation
I copied all urls from (minus the `/archive/...`):
```ShellSession
$ nix repl
> :l .
> lib.map (p: p.src.url) (lib.attrValues (callPackage ./pkgs/applications/editors/vim/plugins/luaPackagePlugins.nix { inherit (neovimUtils) buildNeovimPlugin; } {} {}))
```
`buildNeovimPlugin` ignores vim directories such as `plugin` which might still be helpful ref: NixOS#407318
Byproduct of running newer ruff
nix-owners
bot
requested review from
GaetanLepage,
PerchunPak,
khaneliman and
mrcjkb
dtomvan
added
9.needs: reporter feedback
Contributor
Author
|
Outpaths fail, because |
Member
Contributor
Author
|
Ah, okay, thank you for the explanation. I guess bet on #344320 then? Or also too hacky? In any case, I think reporter's bug still exists after that. Could the luarocks package filter get toned down a bit then? |
Member
|
I have no idea tbh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May fix #407318
Not sure if this is the way...
luaPackagePlugins(addedwarnOnInstantiate)buildNeovimPluginfor generated plugin definitionsgenerated.nixNote
Note that this doesn't mean that
buildNeovimPluginis deprecated/removed, just unused from this point for generated plugins, as it can create unwanted behavior according to linked issueTested by building
vimPlugins.gitsigns-nvim. Output has more stuff in it, package name now no longer containslua5.1, warning doesn't get thrown. Should most likely work in real neovim installations as they are as close to the original source now as possible.TODO
nix-build -A neovim.passthru.tests --keep-goingworks, except for:nvim-cmpandplenary.nvim'sneovimRequireCheckHooknow fail because it expects somespecfiles to exist which presumably only get built for the luarocks variation. We could keep those two as the onlyluaPackagePluginsinvimPlugins?vimaccidentally?I just worked on this for a bit, until I thought it was good enough. I'd like a little bit of feedback on this. Maybe this isn't wanted or polished enough, but I thought this would be a way to make those
vimPluginsa little more unified.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.