Skip to content

emacs: set version tests as true #408522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jian-lin merged 1 commit into from
May 18, 2025
Merged

emacs: set version tests as true #408522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkgs/applications/editors/emacs/make-emacs.nix
View file
Open in desktop
Copy link
Contributor

@jian-lin jian-lin May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one remaining version check for 29:

nixpkgs/pkgs/applications/editors/emacs/make-emacs.nix

Line 173 in 07cfbb7

if lib.versionOlder finalAttrs.version "29" then
. Do you indent to leave that untouched?

Copy link
Member Author

@AndersonTorres AndersonTorres May 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not touch this check here.

This test controls the inclusion of an outdated patch, and it is covered by the commits below:

I think it is better to split them in another step.

Edit:

On the other hand, a new commit can be added in this PR. Let's see...

Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,13 @@
withNS ? stdenv.hostPlatform.isDarwin && !(variant == "macport" || noGui),
withPgtk ? false,
withSelinux ? stdenv.hostPlatform.isLinux,
withSQLite3 ? lib.versionAtLeast version "29",
withSQLite3 ? true,
withSystemd ? lib.meta.availableOn stdenv.hostPlatform systemd,
withToolkitScrollBars ? true,
withTreeSitter ? lib.versionAtLeast version "29",
withWebP ? lib.versionAtLeast version "29",
withTreeSitter ? true,
withWebP ? true,
withX ? !(stdenv.hostPlatform.isDarwin || noGui || withPgtk),
withXinput2 ? withX && lib.versionAtLeast version "29",
withXinput2 ? withX,
withXwidgets ?
!stdenv.hostPlatform.isDarwin
&& !noGui
Expand Down