ci/eval: remove left-over stats.json#408411
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom May 22, 2025
Merged
Conversation
github-actions
bot
added
6.topic: continuous integration
github-actions
bot
added
10.rebuild-darwin: 0
philiptaron
approved these changes
May 18, 2025
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
This helps my work on restructuring the combine/comparison steps to squeeze out a bit more performance.
Excellent.
This seems to be a left-over from before the performance comparison was changed to a difference-per-chunk analysis.
wolfgangwalther
force-pushed
the
ci-stats-leftover
branch
from
53d27e5 to
edaf51c
Compare
Contributor
|
Successfully created backport PR for |
1 task
nixpkgs-ci
bot
added
the
8.has: port to stable
Member
|
@wolfgangwalther Just wanna say thanks for all the work on improving GHA CI recently! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be a left-over from before the performance comparison was changed to a difference-per-chunk analysis.
It was introduced in #356023, but is imho superseded by #395113. The
stats.jsonfile is not used and I doubt that anyone is looking at it by downloading the artifacts manually instead of looking at the nice markdown table in the workflow summary.The same numbers are still available in the intermediate artifacts, just not aggregated across the four systems anymore.
This helps my work on restructuring the combine/comparison steps to squeeze out a bit more performance.
Things done
Add a 👍 reaction to pull requests you find important.