code-cursor: 0.49.6 -> 0.50.5#408257
Conversation
4d2ae43 to
966b8bd
Compare
|
aspauldingcode
left a comment
There was a problem hiding this comment.
Looks fine to me. :) excited to have a co-maintainer!
|
Closes #408766 |
sarahec
left a comment
There was a problem hiding this comment.
LGTM. You may want to bump this to 0.50.5 via the update script.
|
(Just because I left the maintainers list doesn't mean I won't help you out when I can.) |
Wow, you weren't kidding when you said cursor has a quick release window/cycle. |
966b8bd to
c009926
Compare
|
TYSM. Looks good! |
It's one of the things that drove me nuts. They used to drop updates far too quickly and they'd usually be broken, needing another immediate update. That model doesn't work well with nix where people expect stability. The cursor team has become much more disciplined. They started differentiating between stable and prerelease ("latest" in the api). On the other hand, people will demand that you give them the prereleases; it's a bad idea and I hope you two can resist the temptation. Remain on stable, even if prerelease dangles tantalizing treats before your eyes, and life will be much easier. P.S. The reason I left as a maintainer is I was tired of being bombarded by requests (usually for the latest unstable, or to support some weird configuration) by people who weren't willing to do the work. Have good boundaries and hold to them. |
|
One more note about "latest" (prerelease) vs. "stable" in the API. Their paid support works with the stable releases only. You can also give a new stqable release a week or two to settle then backport it to |
|
Would it better if we have two package "code-cursor" and "code-cursor-latest"? |
I've thought about that before. They don't have a consistent "rolling" branch established so "stable" could get ahead of "latest". You'd also have the same problem that early cursor had: shipping a release and shipping the next one before the first had ever made it through hydra. Then you get people mad at you for not shipping the absolute latest. You also piss off the core maintainers who would (eventually) merge your PR -- many of them aren't fond of closed-source to begin with, let again releases that change every few days. How much time are you willing to spend maintaining this? I used to be on the forums daily as well as responding to bugs and working to improve the derivation and updateScript. In the past five months, I've probably spent three months of that keeping this package going. (That's three months of 100% working time.) If you move from "stable" to "latest", you can expect to spend that kind of time. If somebody really wants to run the latest prerelease, nix can be configured to run an AppImage directly. If I were you, I would focus on developing the relationships and understanding the communications channels so you can get this merged right after an update. |
|
is it 'normal' for |
There are no passthru tests in this derivation. Something else must be hanging that builder. |
|
Interesting, GitHub says it's 'Queued — Waiting to run this check...' |
|
Thanks! |
|
FYI, there's a progress tracker for PRs: https://nixpk.gs/pr-tracker.html?pr=408257 |
Release notes: https://www.cursor.com/changelog
Closes #408238.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.