Closed
Conversation
0030cde to
bc4bc47
Compare
d06b392 to
18f71f6
Compare
68f005b to
0997c73
Compare
daa5271 to
9a8447f
Compare
261b4c1 to
996b13b
Compare
Contributor
Author
|
Contributor
Author
|
Build of Therion on aarch64-darwin is a known failure. https://hydra.nixos.org/build/298267154. Hi, @tfmoraes still active in maintaining these related packages? |
Contributor
Author
|
This was referenced May 25, 2025
Contributor
Author
|
13 tasks
13 tasks
Contributor
Author
|
Closed in favor of #417613 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vtk packages has been outdated for a while since upgrading the vtk packages may broke lots of package depends on it.
Also, the current vtk package recipe is not tested, we are not sure if updating vtk source to 9.4.2 also works fine at runtime.
This pr add vtk 9.4.2 that has been tested/fixed on x86-64-linux platform, it works fine with downstream pyvsita on both x86-64-linux and aarch64-darwin platform.
The check depends on the newly created hooks headlessDIsplayHook that can be reused by downstream pyvista* packages in nativeCheckInputs.
added 2025-05-19
the vtk-config.cmake requires nearly all its buildInputs as propagatedBuildInputs, for downstream package maintainers that use vtk as buildInputs, please check your buildInputs, some maybe required by the vtk-config.cmake and they are now propagated by vtk, so you should remove thouse deplicated buildInputs. e.g.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.