Skip to content

Revert "iasl: 20180313 -> 20180508 (#40613)"#40781

Closed
Synthetica9 wants to merge 1 commit intoNixOS:gcc8from
Synthetica9:gcc8-iasl-revert
Closed

Revert "iasl: 20180313 -> 20180508 (#40613)"#40781
Synthetica9 wants to merge 1 commit intoNixOS:gcc8from
Synthetica9:gcc8-iasl-revert

Conversation

@Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented May 19, 2018

Broke xen and virtualbox.
This reverts commit 5e49920.

Motivation for this change

See #40613 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Broke xen and virtualbox.
This reverts commit 5e49920.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 19, 2018
@xeji
Copy link
Contributor

xeji commented May 19, 2018

@Synthetica9 to have a clean git history, the revert commit should reference the original commit on the gcc8 branch (not the one on master).
Reverted in a581c10 , closing this.

@xeji xeji closed this May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants