Skip to content

taler-wallet-core: correct broken condition#407498

Closed
Aleksanaa wants to merge 1 commit intoNixOS:masterfrom
Aleksanaa:taler-wallet-core
Closed

taler-wallet-core: correct broken condition#407498
Aleksanaa wants to merge 1 commit intoNixOS:masterfrom
Aleksanaa:taler-wallet-core

Conversation

@Aleksanaa
Copy link
Member

Correct #407039

Using .config instead of lib.system.equals because it's config passed here that matters, not others (like gcc.arch)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 16, 2025
@FliegendeWurst
Copy link
Member

The previous condition lines up with the configurePlatforms definition. (Which directly influences the --build / --host flags)

configurePlatforms ?
optionals (stdenv.hostPlatform != stdenv.buildPlatform || config.configurePlatformsByDefault)
[
"build"
"host"
],

@Aleksanaa
Copy link
Member Author

Aleksanaa commented May 16, 2025

The previous condition lines up with the configurePlatforms definition. (Which directly influences the --build / --host flags)

Okay, that is probably wrong too. See #278001 and #380005.

You can just put it here as we have to solve much more than this, and it doesn't help here in the short term.

@Aleksanaa Aleksanaa closed this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants