Skip to content

Revert "file: 5.45 -> 5.46", to fix Zip files regressions#407304

Merged
wolfgangwalther merged 1 commit intoNixOS:stagingfrom
doronbehar:pkg/file@5.46-revert
May 16, 2025
Merged

Revert "file: 5.45 -> 5.46", to fix Zip files regressions#407304
wolfgangwalther merged 1 commit intoNixOS:stagingfrom
doronbehar:pkg/file@5.46-revert

Conversation

@doronbehar
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 15, 2025
This reverts commit 75d2d3c, after
multiple complains best summarized here:

NixOS#402318 (comment)
@doronbehar doronbehar force-pushed the pkg/file@5.46-revert branch from 8f99243 to 7377f9e Compare May 16, 2025 07:29
@doronbehar
Copy link
Contributor Author

I sort of reviewed myself due to lack of comments, and modified the comment around the 32-bit-time_t.patch to explain the situation. Will merge when CI is green.

@wolfgangwalther wolfgangwalther merged commit ff9c1af into NixOS:staging May 16, 2025
20 of 21 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 16, 2025

Successfully created backport PR for staging-25.05:

@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 16, 2025
@trofi trofi mentioned this pull request Jun 23, 2025
13 tasks
@doronbehar doronbehar deleted the pkg/file@5.46-revert branch February 10, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants