Skip to content

f2: 2.0.3 -> 2.1.1#407252

Merged
r-vdp merged 3 commits intoNixOS:masterfrom
Prince213:pkgs/f2-2.1.0-unstable-2025-05-03
May 17, 2025
Merged

f2: 2.0.3 -> 2.1.1#407252
r-vdp merged 3 commits intoNixOS:masterfrom
Prince213:pkgs/f2-2.1.0-unstable-2025-05-03

Conversation

@Prince213
Copy link
Member

@Prince213 Prince213 commented May 15, 2025

Release notes:

Closes #407201 (issue requested 2.1.0).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 15, 2025
@Prince213
Copy link
Member Author

Format check failure is caused by #407248.

@Prince213 Prince213 added the 8.has: package (update) This PR updates a package to a newer version label May 15, 2025
@Prince213 Prince213 force-pushed the pkgs/f2-2.1.0-unstable-2025-05-03 branch 2 times, most recently from ff562ac to f496a53 Compare May 15, 2025 06:05
@nadir-ishiguro
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 407252


x86_64-linux

✅ 1 package built:
  • f2

@nadir-ishiguro
Copy link
Contributor

Builds and works as expected. There was also a nightly released a few hours ago, which definitely also works.

Hadn't seen this PR before trying that, thank you for working on this.

I know I was the one opening the update request issue, but maybe there's a release coming, as upstream was made aware of the issue. So we could also just wait for that. I think either way is fine.

@Prince213
Copy link
Member Author

Let's ping the maintainer then.
If we can get this merged before the new upstream version then that's great.
Otherwise I'll update to that version.

@Prince213
Copy link
Member Author

@zendo PTAL (Can't seem to request you to review)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 15, 2025
@nadir-ishiguro
Copy link
Contributor

https://github.com/ayoisaiah/f2/releases/tag/v2.1.1 just came out and builds and works fine, so we can just use the proper release.

@Prince213 Prince213 force-pushed the pkgs/f2-2.1.0-unstable-2025-05-03 branch from f496a53 to 74453f2 Compare May 16, 2025 11:22
@Prince213 Prince213 changed the title f2: 2.0.3 -> 2.1.0-unstable-2025-05-03 f2: 2.0.3 -> 2.1.1 May 16, 2025
@nadir-ishiguro
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 407252


x86_64-linux

✅ 1 package built:
  • f2

@nadir-ishiguro
Copy link
Contributor

Thank you. I had noticed that the --version flag didn't show the proper result, but wasn't aware of how to fix that. Much better

@Prince213 Prince213 added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 17, 2025
@r-vdp r-vdp merged commit 7a7abee into NixOS:master May 17, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Request: f2 2.0.3 → 2.1.0

6 participants