Skip to content

zed-editor: 0.184.10 -> 0.186.8#407051

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
WHForks:zed-update
May 14, 2025
Merged

zed-editor: 0.184.10 -> 0.186.8#407051
GaetanLepage merged 1 commit intoNixOS:masterfrom
WHForks:zed-update

Conversation

@WeetHet
Copy link
Contributor

@WeetHet WeetHet commented May 14, 2025

Supersedes: #404938

This need a couple of patches to work, thanks to @TomaSajt for providing one to de-duplicate dependencies

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@WeetHet
Copy link
Contributor Author

WeetHet commented May 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 407051


aarch64-darwin

✅ 2 packages built:
  • zed-editor
  • zed-editor.remote_server

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 14, 2025
@niklaskorz niklaskorz mentioned this pull request May 14, 2025
13 tasks
@WeetHet
Copy link
Contributor Author

WeetHet commented May 14, 2025

There's some weird stuff going on when I'm trying to build this in my Linux VM, I'm getting a panic at
https://github.com/rust-secure-code/cargo-auditable/blob/ceb4475d237b0296a3ddb946e0337fb658743ccc/cargo-auditable/src/rustc_wrapper.rs#L109

which would indicate that the rustc command that cargo-auditable spawns is terminated by a signal

@niklaskorz
Copy link
Member

There's some weird stuff going on when I'm trying to build this in my Linux VM, I'm getting a panic at https://github.com/rust-secure-code/cargo-auditable/blob/ceb4475d237b0296a3ddb946e0337fb658743ccc/cargo-auditable/src/rustc_wrapper.rs#L109

which would indicate that the rustc command that cargo-auditable spawns is terminated by a signal

Might just be OOM? Currently building on x86_64-linux (no VM), let's see

@WeetHet WeetHet changed the title zed-editor: 0.184.10 -> 0.186.7 zed-editor: 0.184.10 -> 0.186.8 May 14, 2025
@WeetHet
Copy link
Contributor Author

WeetHet commented May 14, 2025

Might just be OOM? Currently building on x86_64-linux (no VM), let's see

Hopefully. I was building on a 64gb RAM machine so I'm not sure

@TomaSajt
Copy link
Contributor

Did my patch actually work? Last time I checked, it failed, but I guess maybe the dependency that failed has been updated? IDK.

@WeetHet
Copy link
Contributor Author

WeetHet commented May 14, 2025

Did my patch actually work? Last time I checked, it failed, but I guess maybe the dependency that failed has been updated? IDK.

I had to fix the dependency manually

@Tebro
Copy link
Contributor

Tebro commented May 14, 2025

Just built and tested on NixOS (x86_64-linux) and it seems to work. Only problem I am having is that it forgets my zed login on each restart. But I had that with other builds as well.

@niklaskorz
Copy link
Member

Might just be OOM? Currently building on x86_64-linux (no VM), let's see

Hopefully. I was building on a 64gb RAM machine so I'm not sure

Builds fine here on x86_64-linux

@WeetHet
Copy link
Contributor Author

WeetHet commented May 14, 2025

Eval failed, what?

@niklaskorz
Copy link
Member

Eval failed, what?

#407070

Co-authored-by: WeetHet <stas.ale66@gmail.com>
Co-authored-by: TomaSajt <62384384+TomaSajt@users.noreply.github.com>
@WeetHet WeetHet requested a review from TomaSajt May 14, 2025 16:49
Copy link
Contributor

@TomaSajt TomaSajt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage GaetanLepage merged commit 759a78a into NixOS:master May 14, 2025
23 of 27 checks passed
@GaetanLepage
Copy link
Contributor

Thanks guys!

@WeetHet WeetHet deleted the zed-update branch May 14, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants