Skip to content

elfutils: add patch that fixes compilation under gcc8 #40705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xeji merged 2 commits into from
May 18, 2018
Merged

elfutils: add patch that fixes compilation under gcc8 #40705

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8787699
elfutils: add patch that fixes compilation under gcc8
Synthetica9 May 17, 2018
c16d9ec
elfutils: follow advice from @jtojnar
Synthetica9 May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pkgs/development/tools/misc/elfutils/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ lib, stdenv, fetchurl, m4, zlib, bzip2, bison, flex, gettext, xz, setupDebugInfoDirs }:
{ lib, stdenv, fetchurl, m4, zlib, bzip2, bison, flex, gettext, xz, setupDebugInfoDirs, fetchpatch }:

# TODO: Look at the hardcoded paths to kernel, modules etc.
stdenv.mkDerivation rec {
Expand All @@ -10,7 +10,14 @@ stdenv.mkDerivation rec {
sha256 = "0rp0r54z44is49c594qy7hr211nhb00aa5y7z74vsybbaxslg10z";
};

patches = ./debug-info-from-env.patch;
patches = [
./debug-info-from-env.patch
(fetchpatch {

@jtojnar jtojnar May 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchurl should be enough here, it is just a static file.

@jtojnar jtojnar May 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep the source comment, or mention that it is for GCC 8, or something

name = "0001-Ensure-that-packed-structs-follow-the-gcc-memory-lay.patch";
url = http://git.openembedded.org/openembedded-core/plain/meta/recipes-devtools/elfutils/files/0001-Ensure-that-packed-structs-follow-the-gcc-memory-lay.patch?id=49aae1d75ff1c6a9643c30a8cc5776a2ffa83dd3;
sha256 = "09y4x1yaqm84w7cy1sf57a6g8ah49b0349dsj2a81wy4flw8ih5j";
})
];

@jtojnar jtojnar May 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dedent this.


hardeningDisable = [ "format" ];

Expand Down