Skip to content

papers: 47.3 -> 48.2#406739

Closed
MangoIV wants to merge 1 commit intoNixOS:stagingfrom
MangoIV:mangoiv/papers
Closed

papers: 47.3 -> 48.2#406739
MangoIV wants to merge 1 commit intoNixOS:stagingfrom
MangoIV:mangoiv/papers

Conversation

@MangoIV
Copy link
Contributor

@MangoIV MangoIV commented May 13, 2025

Previously: #406737

Things done

updated papers

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@MangoIV
Copy link
Contributor Author

MangoIV commented May 13, 2025

This makes papers much more usable

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 13, 2025
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, skimmed NEWS and changes to meson files, looking mostly okay: https://gitlab.gnome.org/GNOME/Incubator/papers/-/compare/47.3...48.2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to get this into NixOS 25.05, you should target staging-next branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I somehow change the base branch for this PR or do I have to change base, close the PR and open it again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do it in the edit button at the top of the PR.

But since this branch already contains commits that are not in staging-next branch, you will need to drop them (e.g. git rebase --interactive $(git merge-base HEAD staging-next)) and then force push.

@MangoIV
Copy link
Contributor Author

MangoIV commented May 13, 2025

I guess I will close and reopen again lol

@MangoIV MangoIV closed this May 13, 2025
@jtojnar
Copy link
Member

jtojnar commented May 13, 2025

Re-submitted as #406778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants