Conversation
|
This makes papers much more usable |
jtojnar
left a comment
There was a problem hiding this comment.
Thanks, skimmed NEWS and changes to meson files, looking mostly okay: https://gitlab.gnome.org/GNOME/Incubator/papers/-/compare/47.3...48.2
There was a problem hiding this comment.
If you want to get this into NixOS 25.05, you should target staging-next branch.
There was a problem hiding this comment.
can I somehow change the base branch for this PR or do I have to change base, close the PR and open it again?
There was a problem hiding this comment.
You can do it in the edit button at the top of the PR.
But since this branch already contains commits that are not in staging-next branch, you will need to drop them (e.g. git rebase --interactive $(git merge-base HEAD staging-next)) and then force push.
|
I guess I will close and reopen again lol |
|
Re-submitted as #406778 |
Previously: #406737
Things done
updated papers
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.