harfbuzz: default withCoreText to true on darwin#406734
Merged
wolfgangwalther merged 1 commit intoNixOS:stagingfrom May 16, 2025
Merged
harfbuzz: default withCoreText to true on darwin#406734wolfgangwalther merged 1 commit intoNixOS:stagingfrom
wolfgangwalther merged 1 commit intoNixOS:stagingfrom
Conversation
Member
Author
|
0608854 to
07b7b9f
Compare
07b7b9f to
0d6b5f8
Compare
Member
Author
|
Member
Author
|
Running md2pdf still results in a segfault: ➜ nixpkgs git:(weasyprint) ./result/bin/md2pdf README.md output.pdf
Fontconfig error: Cannot load default config file: No such file: (null)
Fontconfig error: Cannot load default config file: No such file: (null)
Fontconfig error: Cannot load default config file: No such file: (null)
[1] 24748 segmentation fault ./result/bin/md2pdf README.md output.pdfI can probably make a wrapper to make the binary work, but importing this as a python module won't. Any ideas what to do? |
dotlambda
reviewed
May 13, 2025
0d6b5f8 to
5eff7da
Compare
5eff7da to
0e94a10
Compare
Member
Author
|
0e94a10 to
08065e4
Compare
Contributor
|
With this change, we can now remove the pango override in all-packages. Maybe more? |
08065e4 to
6457e0f
Compare
Contributor
|
Given the number of rebuilds, this would now need to target staging. |
6457e0f to
2f48f7c
Compare
3 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #406614
weasyprint is segfaulting on darwin due to font issues: https://hydra.nixos.org/build/296850162
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.