Skip to content

harfbuzz: default withCoreText to true on darwin#406734

Merged
wolfgangwalther merged 1 commit intoNixOS:stagingfrom
amadejkastelic:weasyprint
May 16, 2025
Merged

harfbuzz: default withCoreText to true on darwin#406734
wolfgangwalther merged 1 commit intoNixOS:stagingfrom
amadejkastelic:weasyprint

Conversation

@amadejkastelic
Copy link
Member

@amadejkastelic amadejkastelic commented May 13, 2025

Resolves #406614

weasyprint is segfaulting on darwin due to font issues: https://hydra.nixos.org/build/296850162

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 13, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 13, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 13, 2025
@amadejkastelic
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 406734


aarch64-darwin

⏩ 6 packages marked as broken and skipped:
  • python312Packages.trytond
  • python312Packages.trytond.dist
  • python313Packages.trytond
  • python313Packages.trytond.dist
  • trytond
  • trytond.dist
❌ 6 packages failed to build:
  • md2pdf (python312Packages.md2pdf)
  • md2pdf.dist (python312Packages.md2pdf.dist)
  • python313Packages.md2pdf
  • python313Packages.md2pdf.dist
  • python313Packages.presenterm-export
  • python313Packages.presenterm-export.dist
✅ 14 packages built:
  • python312Packages.dnachisel
  • python312Packages.dnachisel.dist
  • python312Packages.flametree
  • python312Packages.flametree.dist
  • python312Packages.presenterm-export
  • python312Packages.presenterm-export.dist
  • python312Packages.weasyprint
  • python312Packages.weasyprint.dist
  • python313Packages.dnachisel
  • python313Packages.dnachisel.dist
  • python313Packages.flametree
  • python313Packages.flametree.dist
  • python313Packages.weasyprint
  • python313Packages.weasyprint.dist

@github-actions github-actions bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 13, 2025
@amadejkastelic
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 406734


aarch64-darwin

⏩ 6 packages marked as broken and skipped:
  • python312Packages.trytond
  • python312Packages.trytond.dist
  • python313Packages.trytond
  • python313Packages.trytond.dist
  • trytond
  • trytond.dist
❌ 2 packages failed to build:
  • python313Packages.presenterm-export
  • python313Packages.presenterm-export.dist
✅ 18 packages built:
  • md2pdf (python312Packages.md2pdf)
  • md2pdf.dist (python312Packages.md2pdf.dist)
  • python312Packages.dnachisel
  • python312Packages.dnachisel.dist
  • python312Packages.flametree
  • python312Packages.flametree.dist
  • python312Packages.presenterm-export
  • python312Packages.presenterm-export.dist
  • python312Packages.weasyprint
  • python312Packages.weasyprint.dist
  • python313Packages.dnachisel
  • python313Packages.dnachisel.dist
  • python313Packages.flametree
  • python313Packages.flametree.dist
  • python313Packages.md2pdf
  • python313Packages.md2pdf.dist
  • python313Packages.weasyprint
  • python313Packages.weasyprint.dist

@amadejkastelic
Copy link
Member Author

amadejkastelic commented May 13, 2025

Running md2pdf still results in a segfault:

➜  nixpkgs git:(weasyprint) ./result/bin/md2pdf README.md output.pdf
Fontconfig error: Cannot load default config file: No such file: (null)
Fontconfig error: Cannot load default config file: No such file: (null)
Fontconfig error: Cannot load default config file: No such file: (null)
[1]    24748 segmentation fault  ./result/bin/md2pdf README.md output.pdf

I can probably make a wrapper to make the binary work, but importing this as a python module won't. Any ideas what to do?

@amadejkastelic amadejkastelic marked this pull request as ready for review May 13, 2025 13:40
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 13, 2025
@amadejkastelic amadejkastelic requested a review from dotlambda May 13, 2025 17:08
@amadejkastelic amadejkastelic changed the title python3Packages.weasyprint: fix darwin tests segfault python3Packages.weasyprint: build harfbuzz with CoreText on darwin May 13, 2025
@nix-owners nix-owners bot requested a review from natsukium May 13, 2025 17:09
@amadejkastelic
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 406734


aarch64-darwin

⏩ 6 packages marked as broken and skipped:
  • python312Packages.trytond
  • python312Packages.trytond.dist
  • python313Packages.trytond
  • python313Packages.trytond.dist
  • trytond
  • trytond.dist
❌ 2 packages failed to build:
  • python313Packages.presenterm-export
  • python313Packages.presenterm-export.dist
✅ 18 packages built:
  • md2pdf (python312Packages.md2pdf)
  • md2pdf.dist (python312Packages.md2pdf.dist)
  • python312Packages.dnachisel
  • python312Packages.dnachisel.dist
  • python312Packages.flametree
  • python312Packages.flametree.dist
  • python312Packages.presenterm-export
  • python312Packages.presenterm-export.dist
  • python312Packages.weasyprint
  • python312Packages.weasyprint.dist
  • python313Packages.dnachisel
  • python313Packages.dnachisel.dist
  • python313Packages.flametree
  • python313Packages.flametree.dist
  • python313Packages.md2pdf
  • python313Packages.md2pdf.dist
  • python313Packages.weasyprint
  • python313Packages.weasyprint.dist

@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label May 14, 2025
@amadejkastelic amadejkastelic changed the title python3Packages.weasyprint: build harfbuzz with CoreText on darwin harfbuzz: default withCoreText to true on darwin May 14, 2025
@wolfgangwalther
Copy link
Contributor

With this change, we can now remove the pango override in all-packages. Maybe more?

@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels May 14, 2025
@wolfgangwalther
Copy link
Contributor

Given the number of rebuilds, this would now need to target staging.

@amadejkastelic amadejkastelic changed the base branch from master to staging May 15, 2025 07:09
@wolfgangwalther wolfgangwalther merged commit eeba612 into NixOS:staging May 16, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python311Packages.weasyprint: Fatal Python error: Segmentation fault on aarch64-darwin

3 participants