chawan: 0-unstable-2025-04-18 -> 0-unstable-2025-05-25#406717
chawan: 0-unstable-2025-04-18 -> 0-unstable-2025-05-25#406717pbsds merged 2 commits intoNixOS:masterfrom
Conversation
* Add missing brotli dependency Without the Brotli development library, linking fails with the following error: > gcc: error: libbrotlidec: linker input file not found: no such file or directory * Remove unused variable
This comment was marked as outdated.
This comment was marked as outdated.
|
|
@jtbx Any thoughts or feedback on this PR? |
jtbx
left a comment
There was a problem hiding this comment.
Yeah looks good thanks could you possibly squash the two commits?
|
Thank you for the review! I believe it's better to keep the commits separate in this case. Doing so clarifies the specific timing when Brotli is required and makes it easier to revert the second commit if needed. Of course, if there's a guiding principle that recommends squashing these commits, I'm happy to respect that. However, based on my understanding of patterns like those seen in #400934, this particular situation doesn't seem to fit the typical use case for squashed commits. That said, since the documentation PR is still under discussion and not yet merged, I'm happy to follow the package maintainer's suggestion if you think squashing is indeed better for this pattern. |
|
Kenichi Kamiya writes:
Thank you for the review!
I believe it's better to keep the commits separate in this case. Doing
so clarifies the specific timing when Brotli is required and makes it
easier to revert the second commit if needed.
Sweet, makes sense
|
This PR aims to fix the failing automatic updater: https://nixpkgs-update-logs.nix-community.org/chawan/2025-05-04.log
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.