Skip to content

chawan: 0-unstable-2025-04-18 -> 0-unstable-2025-05-25#406717

Merged
pbsds merged 2 commits intoNixOS:masterfrom
kachick:update-chawan
Jun 4, 2025
Merged

chawan: 0-unstable-2025-04-18 -> 0-unstable-2025-05-25#406717
pbsds merged 2 commits intoNixOS:masterfrom
kachick:update-chawan

Conversation

@kachick
Copy link
Member

@kachick kachick commented May 13, 2025

This PR aims to fix the failing automatic updater: https://nixpkgs-update-logs.nix-community.org/chawan/2025-05-04.log

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

* Add missing brotli dependency
  Without the Brotli development library, linking fails with the following error:
  > gcc: error: libbrotlidec: linker input file not found: no such file or directory

* Remove unused variable
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 13, 2025
@nix-owners nix-owners bot requested a review from jtbx May 13, 2025 09:24
@kachick

This comment was marked as outdated.

@kachick kachick changed the title chawan: 0-unstable-2025-04-18 -> 0-unstable-2025-05-13 chawan: 0-unstable-2025-04-18 -> 0-unstable-2025-05-25 May 26, 2025
@kachick
Copy link
Member Author

kachick commented May 26, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 406717
Commit: 542dc8f4aeb49bc44566fd153db6bb35716fed1d


x86_64-linux

✅ 1 package built:
  • chawan

aarch64-linux

✅ 1 package built:
  • chawan

x86_64-darwin

✅ 1 package built:
  • chawan

aarch64-darwin

✅ 1 package built:
  • chawan

@kachick
Copy link
Member Author

kachick commented May 26, 2025

@jtbx Any thoughts or feedback on this PR?

Copy link
Member

@jtbx jtbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good thanks could you possibly squash the two commits?

@kachick
Copy link
Member Author

kachick commented May 27, 2025

Thank you for the review!

I believe it's better to keep the commits separate in this case. Doing so clarifies the specific timing when Brotli is required and makes it easier to revert the second commit if needed.

Of course, if there's a guiding principle that recommends squashing these commits, I'm happy to respect that. However, based on my understanding of patterns like those seen in #400934, this particular situation doesn't seem to fit the typical use case for squashed commits.

That said, since the documentation PR is still under discussion and not yet merged, I'm happy to follow the package maintainer's suggestion if you think squashing is indeed better for this pattern.

@jtbx
Copy link
Member

jtbx commented May 27, 2025 via email

@kachick kachick added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 27, 2025
@pbsds pbsds merged commit 76b87fd into NixOS:master Jun 4, 2025
19 of 20 checks passed
@kachick kachick deleted the update-chawan branch June 4, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants