Skip to content

[24.11] teams-for-linux: 1.12.7 -> 1.13.1#406703

Merged
khaneliman merged 3 commits intoNixOS:release-24.11from
teutat3s:teams-for-linux-backports
May 16, 2025
Merged

[24.11] teams-for-linux: 1.12.7 -> 1.13.1#406703
khaneliman merged 3 commits intoNixOS:release-24.11from
teutat3s:teams-for-linux-backports

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented May 13, 2025

Related to #406422

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 4.workflow: backport This targets a stable branch label May 13, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 13, 2025
@nix-owners nix-owners bot requested review from chvp, khaneliman, muscaln and qjoly May 13, 2025 08:30
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the application on x86_64-linux with wayland and looking fine by me.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 14, 2025
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Stable seems messed up atm... formatting failure from unrelated code and node is broken on darwin so teams doesn't build there.

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 406703


x86_64-linux

✅ 1 package built:
  • teams-for-linux

aarch64-linux

✅ 1 package built:
  • teams-for-linux

@khaneliman khaneliman merged commit 7f9ea5b into NixOS:release-24.11 May 16, 2025
27 of 28 checks passed
@teutat3s teutat3s deleted the teams-for-linux-backports branch May 17, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants