Skip to content

nixos/udev: verify udev rules with udevadm#406284

Merged
K900 merged 2 commits intoNixOS:masterfrom
r-vdp:master
May 12, 2025
Merged

nixos/udev: verify udev rules with udevadm#406284
K900 merged 2 commits intoNixOS:masterfrom
r-vdp:master

Conversation

@r-vdp
Copy link
Contributor

@r-vdp r-vdp commented May 11, 2025

Things done

Re-apply of #404323, but this time I made sure that the installer tests still pass

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 11, 2025
@r-vdp r-vdp requested a review from K900 May 11, 2025 22:39
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 11, 2025
@r-vdp
Copy link
Contributor Author

r-vdp commented May 11, 2025

@ofborg test installer-simple

@K900
Copy link
Contributor

K900 commented May 12, 2025

@ofborg test installer.simple

@r-vdp
Copy link
Contributor Author

r-vdp commented May 12, 2025

@ofborg test installer.simpleUefiSystemdBoot

@r-vdp
Copy link
Contributor Author

r-vdp commented May 12, 2025

The simple test succeeded on ofborg (but it only runs on x86_64)

@K900 K900 merged commit 5b99c79 into NixOS:master May 12, 2025
31 of 34 checks passed
@LordGrimmauld
Copy link
Contributor

Currently going through all packages with udev rules, i found another broken package:

  • alsa-utils

(might update this list as i find more)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/udev-regression-recommended-way-for-udev-rules/73061/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants