Skip to content

cmctl: modernize, disable integration test differently#406137

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
FliegendeWurst:cmctl-modernize
May 12, 2025
Merged

cmctl: modernize, disable integration test differently#406137
Mic92 merged 1 commit intoNixOS:masterfrom
FliegendeWurst:cmctl-modernize

Conversation

@FliegendeWurst
Copy link
Copy Markdown
Member

Restores the update script, and excludes the integration test more efficiently

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented May 11, 2025

CI error is related to #404466 (comment)
fixed, just needs a rebase.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 11, 2025
@nix-owners nix-owners bot requested a review from JoshVanL May 11, 2025 10:44
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented May 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 406137


x86_64-linux

✅ 1 package built:
  • cmctl

aarch64-linux

✅ 1 package built:
  • cmctl

x86_64-darwin

✅ 1 package built:
  • cmctl

aarch64-darwin

✅ 1 package built:
  • cmctl

@Mic92 Mic92 merged commit 790a5e2 into NixOS:master May 12, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants