Skip to content

workflows/eval-aliases: split from eval#406113

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
wolfgangwalther:ci-eval-aliases
May 11, 2025
Merged

workflows/eval-aliases: split from eval#406113
Mic92 merged 1 commit intoNixOS:masterfrom
wolfgangwalther:ci-eval-aliases

Conversation

@wolfgangwalther
Copy link
Copy Markdown
Contributor

The eval-aliases job is independent of all the other eval jobs. By splitting it into a separate workflow, we avoid running it in two cases:

  1. When turning a PR "ready to review". In this case, the main eval workflow needs to run to be able to tag reviewers - but not eval-aliases.

  2. On branches like master, staging, etc. We only need to run eval there to have a result to compare against in PRs. eval-aliases doesn't contribute to that.

Thus, this will avoid wasting resources.

Things done


Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs backport release-24.11 labels May 11, 2025
The eval-aliases job is independent of all the other eval jobs. By
splitting it into a separate workflow, we avoid running it in two cases:

1. When turning a PR "ready to review". In this case, the main eval
workflow needs to run to be able to tag reviewers - but not
eval-aliases.

2. On branches like master, staging, etc. We only need to run eval there
to have a result to compare against in PRs. eval-aliases doesn't
contribute to that.

Thus, this will avoid wasting resources.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 11, 2025
@Mic92 Mic92 merged commit 7ad3c88 into NixOS:master May 11, 2025
22 of 23 checks passed
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented May 11, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 11, 2025
@wolfgangwalther wolfgangwalther deleted the ci-eval-aliases branch May 11, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants