Skip to content

uvwasi: init at 0.0.21#406004

Merged
FliegendeWurst merged 1 commit intoNixOS:masterfrom
aduh95:uvwasi
May 29, 2025
Merged

uvwasi: init at 0.0.21#406004
FliegendeWurst merged 1 commit intoNixOS:masterfrom
aduh95:uvwasi

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 10, 2025

As part of #401454, I trying to use more shared libs in the hope of reducing build time for nodejs packages.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 10, 2025
@aduh95 aduh95 force-pushed the uvwasi branch 3 times, most recently from 31e9642 to ad91245 Compare May 11, 2025 20:50
@aduh95 aduh95 requested a review from FliegendeWurst May 29, 2025 08:26
@aduh95
Copy link
Contributor Author

aduh95 commented May 29, 2025

I'd like to include this in #401454, I've confirmed I can build nodejs_20, nodejs_22, and nodejs_24 using shared uvwasi from this PR.

@FliegendeWurst FliegendeWurst merged commit d2ebbeb into NixOS:master May 29, 2025
14 of 17 checks passed
@aduh95 aduh95 deleted the uvwasi branch May 29, 2025 10:57
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 29, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants