dependabot-cli.withDockerImages: fix build#405991
Merged
NickCao merged 1 commit intoNixOS:masterfrom May 10, 2025
Merged
Conversation
This has been broken for a while as the updater doesn't do the needful thing to update them. Detected with NixOS/nixpkgs-vet#157 some time ago but I didn't get a chance to take a look until now. NixOS#405049 was the most recent dependabot update.
Contributor
Author
|
I'm planning on self-merging this change if it doesn't get reviewed immediately, as my time budget to dedicate to nixpkgs-vet is limited and this has prevented on-going updates for a while. It'd definitely be better to make the update script do this, but I'm going to defer learning how to do that in favor of unbreaking the nixpkgs-vet update. |
NickCao
approved these changes
May 10, 2025
Member
NickCao
left a comment
NickCao
left a comment
There was a problem hiding this comment.
Diff LGTM, can we also set # nixpkgs-update: no auto update on dependabot-cli (or fix the update script, which might be too much work).
Contributor
Author
|
I'm fine being faulted in with the work for a little bit until I learn how to write the update script. It's just used by nixpkgs-vet at the moment. |
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Thanks, @NickCao. 🙏🏻 |
philiptaron
added a commit
to infinixbot/nixpkgs-check-by-name
that referenced
this pull request
May 10, 2025
This was referenced May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been broken for a while as the updater doesn't do the needful thing to update them.
Detected with NixOS/nixpkgs-vet#157 some time ago but I didn't get a chance to take a look until now.
#405049 was the most recent dependabot update.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)