util-linux: fix mount regression#405952
Conversation
9a61cef to
f98f20f
Compare
|
Too many builds for master. Rebase onto and retarget for staging instead. |
|
This PR should probably be against staging (given the rebuild count) so we pick it up in the next cycle. (e: posted at the same time as the above) |
f98f20f to
724e499
Compare
Done (hopefully everything is now correct^^) |
|
util-linuxMinimal builds just fine. util-linux is going now, but I assume it'll be fine too. Edit: indeed it was. |
|
@alyssais Should this be OK to merge to staging? Just want to make sure it won't affect anything for release given the number of builds. |
|
Just ran into this issue while updating my servers. Is there a workaround while waiting for this PR to be merged? Thanks! |
The only way would be to apply the patch yourself. The |
Is there a way to do that on current |
You would either need to create an overlay or fork nixpkgs and cherry-pick this commit to |
|
In case anyone was wondering why this is in limbo: this was reported mid-25.05 stabilization staging cycle and would require a mass rebuild of everything, so we'll get it into the cycle after release. If this issue affects you, give If this ends up working for people, we can PR it to k3s instead as a short term fix, which will not cause a mass rebuild. Please let me know if you try it! Edit: #407810 |
Worked perfectly for me, and recompilation was really quick. Thanks for the fix! |
Can confirm this fixed it for me. |
|
Excellent! |
Until NixOS#405952 is fixed, we can use our own util-linux to avoid breaking k3s in the release. Revert this commit when that happens.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/solved-downgrade-dependency-to-util-linux-in-a-remote-flake/65132/6 |
Add patch of util-linux/util-linux@7dbfe31
This fixes the issues mentioned here:
Note: For k3s it should be possible to work around the issue by running k3s with
--prefer-bundled-bin. But I was unable to get it working with nixpkgs revision dda3dcd.Edit: actually quite obvious why
--prefer-bundled-bindoes not work. The k3s nix package does not copy over the auxiliary binaries from https://github.com/k3s-io/k3s-root/releases/download/v0.14.1/k3s-root-amd64.tar to the location where the build expects them.CC: @numinit @NixOS/k3s
Things done
I did not yet have enough time to rebuild every package depending on
util-linux.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.