Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
Yarny0
suggested changes
May 10, 2025
Contributor
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
Review per https://github.com/NixOS/nixpkgs/tree/dda3dcd3fe03e991015e9a74b22d35950f264a54/pkgs#package-updates
Reviewed points
- package name fits guidelines
- package version fits guidelines
- package builds on x86_64-linux
- executables tested on ARCHITECTURE
- all depending packages build
- patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
- patches that are remotely available are fetched rather than vendored
More:
- Tested
hplipWithPluginonx86_64-linuxwith an HP LaserJet 1000 printer, after cherry-picking onto recent nixos-unstable: Package builds fine, NixOS loads firmware into printer as soon as printer is connected via USB, prints beautiful test page.
Member
Author
|
@Yarny0 Done. |
Yarny0
approved these changes
May 11, 2025
Contributor
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
Great, thank you @Bot-wxt1221 ! Looks very good to me.
Again tested hplipWithPlugin on x86_64-linux with an HP LaserJet 1000 printer, after cherry-picking onto recent nixos-unstable: Package still builds fine, NixOS loads firmware into printer as soon as printer is connected via USB, prints beautiful test page.
Works flawless for me, should be merged.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2371 |
wegank
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.