tree-wide: use named CUDA versions and CUDA version utilities#405664
Conversation
github-actions
bot
added
the
6.topic: python
ConnorBaker
force-pushed
the
feat/treewide-cuda-use-named-versions
branch
3 times, most recently
from
63b2375 to
d3fd219
Compare
github-actions
bot
added
10.rebuild-darwin: 0
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
I went through the diff and was not able to spot anything wrong. Approved!
Signed-off-by: Connor Baker <ConnorBaker01@gmail.com>
ConnorBaker
force-pushed
the
feat/treewide-cuda-use-named-versions
branch
from
d3fd219 to
bf766a2
Compare
|
Added back the comment block on |
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
Added back the comment block on
libPathI accidentally stripped frompkgs/development/cuda-modules/cutensor/extension.nix.
Ok! I wondered about why you removed it in the first place. All good anyway!
|
|
||
| cudatoolkitDevMerged = symlinkJoin { | ||
| name = "cuda-${cudaPackages.cudaVersion}-dev-merged"; | ||
| name = "cuda-${cudaPackages.cudaMajorMinorVersion}-dev-merged"; |
There was a problem hiding this comment.
I understand the cudaOlder part, but what is the motivation for stripping the version strings?
There was a problem hiding this comment.
Stripping in what way?
There was a problem hiding this comment.
Is cudaVersion guaranteed to be major.minor, or is that just a coincidence
3 participants
Additional cleanup prior to landing more changes from https://github.com/ConnorBaker/cuda-packages/tree/main.
This PR is a tree-wide change which moves from
cudaVersiontocudaMajorMinorVersion, and where possible, makes use of thecudaOlderandcudaAtLeastutility functions incudaPackages.As
cudaVersionhappened to be a major-minor version before this change, there should be no rebuilds.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.