antares: 0.7.29 -> 0.7.35

[hatch01]

Things done

antares: 0.7.29 -> 0.7.34

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[phanirithvij]

I think it is best to de-vendor this huge lock file patch.
My suggestion would be to make a PR to antares for the same and
use https://github.com/antares-sql/antares/pull/<prno>.patch?full_index=1 and fetchpatch2

[Mic92]

I think it is best to de-vendor this huge lock file patch. My suggestion would be to make a PR to antares for the same and use https://github.com/antares-sql/antares/pull/<prno>.patch?full_index=1 and fetchpatch2

Sounds ok in principle. But we may should long-term think about having some place where we can store these forks in case contribute (accidentally) delete them.

[hatch01]

In this pr #335924,
I followed @emilazy advice.
And I think that nixpkgs guidline prefer to keep those kind of path in nixpkgs.

Moreover, I don't really think that the repo checkout is a big problem. As the repo is already huge

[emilazy]

We specifically don’t allow devendoring patches for unmerged GitHub PRs; see #401863 for the latest discussion.

It would be better if upstream fixes this though.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6248