Skip to content

electron{-source,-bin,-chromedriver}: updates#405337

Merged
yuyuyureka merged 9 commits intoNixOS:masterfrom
teutat3s:electron-updates-20250508
May 12, 2025
Merged

electron{-source,-bin,-chromedriver}: updates#405337
yuyuyureka merged 9 commits intoNixOS:masterfrom
teutat3s:electron-updates-20250508

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented May 8, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

teutat3s added 9 commits May 8, 2025 21:02
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 8, 2025
@yuyuyureka
Copy link
Contributor

Building electron_{34,35,36} on aarch64-linux

@yuyuyureka
Copy link
Contributor

Built electron_{34,35,36} on aarch64-linux ✔️

@yuyuyureka yuyuyureka merged commit 496fcd4 into NixOS:master May 12, 2025
33 checks passed
@teutat3s teutat3s deleted the electron-updates-20250508 branch May 12, 2025 06:42
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 12, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-405337-to-release-24.11 origin/release-24.11
cd .worktree/backport-405337-to-release-24.11
git switch --create backport-405337-to-release-24.11
git cherry-pick -x e770d9332904de5cdba9e2d2a513c1177dd8f213 c6c6ce650e000462eae70e0888749cee45fb32b7 39926be5701ed711624702146222aed8b5048e13 5f951320654ce01a5527745b46c1ae84ff6c54c1 b913c75fd1e9b979122f57e0a9bc30e207702c2e 4f5c81b149f5956a2d877c63bc1c51f2b85315ee c6b4255b1554d0151b0bab859358dd6932b7716b 5fe363a61727ee3e67d116ea2e290d9961940175 496fcd4aee87310664b122da5ab7a5568c52e8a2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants