rstudio{,-server}: 2024.12.1+563 -> 2025.05.0+496

[TomaSajt]

Main changes is this PR:

• remove patches that are no longer needed
• add extSrcs
  • upstream unvendored a lot of dependencies in this release
  • FetchContent_Declare and FetchContent_MakeAvailable are used for fetching those dependencies now
  • In extSrcs we treat the file that fetches all the external dependencies as a cmake entrypoint. This causes cmake to fail, but still fetches the dependencies.
• categorize and sort dependencies
  • categorize by role (helper / buildtime / runtime)
  • sort alphabetically (except in nativeBuildInputs)
• put env vars into env = {}
• make nixos test conditional on linux, so hopefully ofborg actually tries to build rstudio
• add changelog

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[b-rodrigues]

tested the desktop version on x86-linux and aarch64-darwin, working flawlessly!

[TomaSajt]

I still have to figure out where ofborg might be failing...

[Kupac]

The server seems to be fully functional on x86_64-linux.

[TomaSajt]

Looks like rstudio/rstudio@e475dba broke quarto installation of rstudio-server on darwin.

Will try to contact upstream about it.

[TomaSajt]

Okay, I just disabled the rstudio-server build on darwin. One guy upstream said that only the electron app is supposed to be built on darwin anyways.

(Btw I tested the older version's rstudio-server (which still built), and it is very broken (many paths are wrong) in the rstudio-server launch script)