makeHardcodeGsettingsPatch: Add support for schemaExistsFunction#405229
Merged
jtojnar merged 2 commits intoNixOS:masterfrom May 8, 2025
Merged
makeHardcodeGsettingsPatch: Add support for schemaExistsFunction#405229jtojnar merged 2 commits intoNixOS:masterfrom
schemaExistsFunction#405229jtojnar merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
jtojnar
force-pushed
the
hardcode-gsettings-schema-exists
branch
from
8f19877 to
fb47527
Compare
evolution-ews introduced a check for optional schemas, which would skip our hardcoded code paths. https://gitlab.gnome.org/GNOME/evolution-ews/-/commit/a0c514bd345c67fe0fd2ed6ef48a25649b1f4d8e Let’s update the semantic patch to also replace the invocations of specified `schemaExistsFunction` for known schemas with `true`.
It has been deprecated for over two years.
jtojnar
force-pushed
the
hardcode-gsettings-schema-exists
branch
from
fb47527 to
34fa007
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evolution-ews introduced a check for optional schemas, which would skip our hardcoded code paths.
https://gitlab.gnome.org/GNOME/evolution-ews/-/commit/a0c514bd345c67fe0fd2ed6ef48a25649b1f4d8e
Let’s update the semantic patch to also replace the invocations of specified
schemaExistsFunctionfor known schemas withtrue.Things done
evolution-ewsupdate work properly GNOME 48 followup #405225tests.makeHardcodeGsettingsPatch.Add a 👍 reaction to pull requests you find important.