signal-desktop: add commandLineArgs for persistent flags#404989
Merged
pbsds merged 1 commit intoNixOS:masterfrom Jun 6, 2025
Merged
signal-desktop: add commandLineArgs for persistent flags#404989pbsds merged 1 commit intoNixOS:masterfrom
pbsds merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
marcin-serwin
approved these changes
May 7, 2025
Member
Author
|
Hey @teutat3s, can you get this reviewed and merged? |
teutat3s
approved these changes
May 13, 2025
teutat3s
added
12.approvals: 2
r-vdp
reviewed
May 17, 2025
| --set-default ELECTRON_FORCE_IS_PACKAGED 1 \ | ||
| --add-flags "\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations --enable-wayland-ime=true}}" | ||
| --add-flags "\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations --enable-wayland-ime=true}}" \ | ||
| --add-flags ${lib.escapeShellArg commandLineArgs} |
Contributor
There was a problem hiding this comment.
Wouldn't it make more sense to use optionalString to avoid adding an extra --add-flags when there's nothing to add?
13 tasks
kachick
approved these changes
May 18, 2025
teutat3s
added
12.approvals: 3+
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
commandLineArgsin arguments and pass it tosignal-desktopmake wrapper to allow custom flags (usually electron related) as practiced in https://github.com/NixOS/nixpkgs/blob/3730d8a308f94996a9ba7c7138ede69c1b9ac4ae/pkgs/by-name/go/google-chrome/package.nixThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.