systemd: enable tests

[balsoft]

It seems that the doCheck = false in the systemd derivation is outdated, as the tests now pass (at least on x86_64-linux).

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[flokli]

This needs to now target staging, due to the number of rebuilds. Please check the contribution guides to do the retargeting without pinging lots of people.

[ElvishJerricco]

All the variants seem to build fine, and of course it shouldn't affect the build output itself in anyway. LGTM

[arianvp]

Euhm what does this actually do? we're still passing tests=false to meson. So what is doCheck = true actually running? (Context: This is giving linker errors on 259 )

[balsoft]

Hmm, this is interesting. I'll take another look.

[balsoft]

Well, at least on 6fa7d77 (master as of me writing this comment), I can confirm that at least some tests are running fine as part of the checkPhase:

Ok:                231
Fail:              0
Skipped:           3

Maybe there's something weird going on with 259? I can take a look.

[arianvp]

Interesting. Lets move the discussion to the 259 WIP PR. Perhaps it ran unit tests but not integration tests? Seems the systemd folks changed something in the meson that broke that use-case

[balsoft]

Perhaps it ran unit tests but not integration tests?

Yes, this sounds likely.