Skip to content

freewheeling: fix build#404620

Merged
risicle merged 2 commits intoNixOS:masterfrom
mjoerg:freewheeling-fix-build
May 8, 2025
Merged

freewheeling: fix build#404620
risicle merged 2 commits intoNixOS:masterfrom
mjoerg:freewheeling-fix-build

Conversation

@mjoerg
Copy link
Contributor

@mjoerg mjoerg commented May 6, 2025

ZHF #403336

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • freewheeling

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 6, 2025
@Sigmanificient Sigmanificient added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 6, 2025
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does build and run, but i can't seem to figure out how to make it output audio.

@booxter
Copy link
Contributor

booxter commented May 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 404620


x86_64-linux

✅ 1 package built:
  • freewheeling

aarch64-linux

✅ 1 package built:
  • freewheeling

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 7, 2025
makeSDLFlags [
SDL
SDL_ttf
SDL_gfx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these possibly needed in a previous version and just never removed? Same with some other dependencies you appear to have been able to just remove..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependencies still exist, but are now being located by pkg-config.
Afaict, only gnutls was actually unused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependencies still exist, but are now being located by pkg-config. Afaict, only gnutls was actually unused.

Correct. gnutls was swapped against nettle upstream, which still was working since nettle is a dependency of gnutls.

@risicle
Copy link
Contributor

risicle commented May 7, 2025

nixpkgs-review happy, nixos x86_64 & aarch64-linux

@mjoerg
Copy link
Contributor Author

mjoerg commented May 8, 2025

Does build and run, but i can't seem to figure out how to make it output audio.

There is a Quick Start Guide, and you can use something like helvum or qpwgraph instead of Jack to connect the inputs and outputs to microphone and speaker.

@risicle risicle merged commit 41aed29 into NixOS:master May 8, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants