ci/eval/nix: 2.24 -> ...#404589
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom May 17, 2025
Merged
Conversation
mweinelt
previously requested changes
May 6, 2025
Member
mweinelt
left a comment
There was a problem hiding this comment.
❯ git log --oneline pinned-nixpkgs.json
ffe6651ecebf Revert "ci: Update pinned Nixpkgs"
0fe5843ab46e ci: Update pinned Nixpkgs
1d6ee7d8eef7 ci: Update pinned Nixpkgs
d51aeeb1fbc7 ci: Update pinned Nixpkgs
d979e89d8811 ci: Update pinned Nixpkgs
c9bbb9962cf7 ci: Update pinned Nixpkgs
7aa5bc804303 ci: Update pinned Nixpkgs
8e1b9b9eb381 ci/pinned-nixpkgs.json: update
b33ac05d043c ci: reusable Nix format Nixpkgs pin
Contributor
|
I'd say we do #404466 first, which will allow us to validate the update of pinned nixpkgs easily locally. |
Contributor
|
pin updated in #406909. |
wolfgangwalther
approved these changes
May 16, 2025
Contributor
wolfgangwalther
left a comment
There was a problem hiding this comment.
Still a slightly preference for using latest here, or anything that is not a pinned version. Doesn't make sense to maintain this on top of the pinned nixpkgs we already have.
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.