[Backport release-24.11] workflows/no-channel: run again when base changed#404464
Merged
wolfgangwalther merged 1 commit intorelease-24.11from May 5, 2025
Merged
Conversation
Because of the branches filter, the job would **not** re-run when only the base-branch was changed, thus leaving the contributor with a failed check. With this change, the job should be triggered and then skipped in this case, so the check in the list should be replaced with a skip. Note, this also means that this step will show up in every PR as skipped, even when it was never failed before. (cherry picked from commit 40963bf)
1 task
github-actions
bot
added
6.topic: continuous integration
Contributor
|
(testing the change itself by changing the branch) |
wolfgangwalther
changed the base branch from
release-24.11
to
nixpkgs-24.11-darwin
github-actions
bot
added
6.topic: python
nix-owners
bot
requested review from
LeSuisse,
Mic92,
infinisil,
mweinelt,
risicle and
zowoq
wolfgangwalther
changed the base branch from
nixpkgs-24.11-darwin
to
release-24.11
github-actions
bot
removed
6.topic: python
Contributor
|
OK, that test was stupid, because it would take the release-24.11 branch's state to (not) run the job. Thus, this just confirms the problem, the "No channel PR" is still there. Will test in a different PR against master for the difference. |
Member
|
What about this one? #404443 |
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
|
I confirmed it in #404466 - the check now appears as skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.11, triggered by a label in #404461.