Skip to content

haskell-generic-builder: Add extra framework dirs#40443

Closed
Ericson2314 wants to merge 1 commit intoNixOS:staging-18.03from
obsidiansystems:cabal-frameworks
Closed

haskell-generic-builder: Add extra framework dirs#40443
Ericson2314 wants to merge 1 commit intoNixOS:staging-18.03from
obsidiansystems:cabal-frameworks

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented May 13, 2018 •
edited
Loading

Motivation for this change

Back-port of #40442

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

CC @ElvishJerricco

@Ericson2314
haskell-generic-builder: Add extra framework dirs
cc6cbfd 
Just like with the other `--extra-*` flags, cc/ld-wrapper already handles
this, but we need to make Cabal aware so that the haskell builds have
the correct metadata.
@Ericson2314 Ericson2314 requested a review from peti as a code owner May 13, 2018 15:06
@Ericson2314 Ericson2314 requested a review from srhb May 13, 2018 15:06
@Ericson2314 Ericson2314 mentioned this pull request May 13, 2018
Merged
8 tasks
@GrahamcOfBorg GrahamcOfBorg added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 13, 2018
@Ericson2314
Copy link
Member Author

Ericson2314 commented May 18, 2018

E.h., if we need to backport stuff as has happened in the past, it can be one big haskell infra cherry-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peti peti Awaiting requested review from peti peti is a code owner

@srhb srhb Awaiting requested review from srhb

Assignees

@peti peti

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ericson2314 @peti @GrahamcOfBorg