Skip to content

SDL2: 2.32.54 -> 2.32.56#404288

Closed
trofi wants to merge 1 commit intoNixOS:stagingfrom
trofi:SDL2-update
Closed

SDL2: 2.32.54 -> 2.32.56#404288
trofi wants to merge 1 commit intoNixOS:stagingfrom
trofi:SDL2-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented May 5, 2025

Changes: https://github.com/libsdl-org/sdl2-compat/releases/tag/release-2.32.56

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi trofi marked this pull request as draft May 5, 2025 05:57
@trofi
Copy link
Contributor Author

trofi commented May 5, 2025

I think it depends on SDL3 update I have locally:

sdl2-compat> /build/source/src/sdl2_compat.c: In function 'Event3to2':
sdl2-compat> /build/source/src/sdl2_compat.c:2339:37: error: 'SDL_MouseWheelEvent' has no member named 'integer_x'
sdl2-compat>  2339 |             wheel->x = event3->wheel.integer_x;
sdl2-compat>       |                                     ^
sdl2-compat> /build/source/src/sdl2_compat.c:2340:37: error: 'SDL_MouseWheelEvent' has no member named 'integer_y'
sdl2-compat>  2340 |             wheel->y = event3->wheel.integer_y;
sdl2-compat>       |                                     ^

Converting to draft.

@trofi
Copy link
Contributor Author

trofi commented May 5, 2025

Depends on:

@github-actions github-actions bot added 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 5, 2025
@nadiaholmquist
Copy link
Contributor

There is another PR that updates both of them, since this depends on the SDL3 update, maybe it's better to focus on that one instead.

@trofi trofi closed this May 5, 2025
@trofi trofi deleted the SDL2-update branch May 5, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants