Skip to content

workflows/labeler: fix conditionals#404152

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
wolfgangwalther:ci-no-label-staging-fix
May 4, 2025
Merged

workflows/labeler: fix conditionals#404152
Mic92 merged 1 commit intoNixOS:masterfrom
wolfgangwalther:ci-no-label-staging-fix

Conversation

@wolfgangwalther
Copy link
Contributor

Introduced in #402332, but broken on all ends*:

  • pull_request needs to be event.pull_request
  • pull_request.head is an object, not a string
  • github.ref_protected is about the target branch, because this runs as a pull_request_target event

Thus, we need to list the branches manually.

* but broken in a way that it would default to the previous behavior in all cases, so not critical.

Things done


Add a 👍 reaction to pull requests you find important.

Introduced in NixOS#402332, but broken on all ends:
- pull_request needs to be event.pull_request
- pull_request.head is an object, not a string
- github.ref_protected is about the target branch, because this runs as
a pull_request_target event

Thus, we need to list the branches manually.
@github-actions github-actions bot added 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels May 4, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 4, 2025
@Mic92 Mic92 merged commit 93e8cdc into NixOS:master May 4, 2025
24 of 27 checks passed
@wolfgangwalther wolfgangwalther deleted the ci-no-label-staging-fix branch May 4, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants