Merged
Conversation
cmake complained about not finding X11_LIBRARIES, which is fixed by providing libXrandr. Adding ninja fixes the installPhase which fails randomly. There is a hack in upstream's CMakeLists.txt file that reads: USES_TERMINAL # Hack: prevent parallel execution (for ninja), c4group tends to fail otherwise This only works with ninja, though. Also enable parallel install phase again, since this seems to work with ninja now. This also fixes the build for aarch64-linux.
This fixes the game at run-time.
Works without them, too.
The ISC license always applies, the unfree part only is added additionally.
github-actions
bot
added
10.rebuild-darwin: 0
wolfgangwalther
added
the
0.kind: ZHF Fixes
wolfgangwalther
commented
May 3, 2025
FKouhai
reviewed
May 3, 2025
Member
|
lluchs
reviewed
May 3, 2025
FKouhai
added
the
12.approvals: 1
lluchs
approved these changes
May 3, 2025
Contributor
lluchs
left a comment
lluchs
left a comment
There was a problem hiding this comment.
Looks good and works on my machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZHF: #403336
Things done
./result/bin/)Add a 👍 reaction to pull requests you find important.